Attention is currently required from: Angel Pons, Jason Glenesk, Julius Werner, Martin L Roth, Stefan Reinauer, Yu-Ping Wu.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75707?usp=email )
Change subject: Rename CBFS master header -> CBFS main header ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75707/comment/40bd75f3_c8ba409e : PS5, Line 9: pupose typo: purpose
https://review.coreboot.org/c/coreboot/+/75707/comment/3976ebc7_9209f763 : PS5, Line 9: Calling it the main header is more descriptive of its pupose : and should therefore be preferred. I don't think that it's more descriptive, rather more confusing. With "main", it suggests that the actual CBFS header is meant and not the one from bootblock. It also suggests that there is some form of a backup or secondary thing. Both terms are not ideal.
Some alternatives: * init * boot (referring to bootblock) * pointer
Patchset:
PS5: Unrelated to my other comment, I think the whole discussion about "master vs main" is too political and I rather would avoid both terms where possible. However, as far as I know, that header is deprecated and should be removed anyway. So I would just leave as it is and get rid of it asap. Otherwise, I suggested some alternatives in my other comment.
File Documentation/releases/coreboot-4.2-relnotes.md:
PS5: I wouldn't change the release notes since they relate to a specific state of the tree.