Attention is currently required from: Felix Singer.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80462?usp=email )
Change subject: mb/starlabs/starbook/{kbl,cml}: Remove libgfxinit code
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
No objection, but libgfxinit does work with GRUB. […]
Likely grub config then - it's just not used at all, and not all boards have it, so I'd prefer them to all the be same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80462?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I86af51f07f29971070bdccc3a589e807425cb83a
Gerrit-Change-Number: 80462
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Fri, 16 Feb 2024 08:28:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment