Attention is currently required from: Arthur Heymans, Christian Walter, Felix Singer, Johnny Lin, Lean Sheng Tan, Tim Chu.
Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75416?usp=email )
Change subject: soc/intel/xeon_sp/spr: Add RMT config
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75416/comment/0353a17c_627c45b4 :
PS3, Line 9: This commit adds a configuration option to enable RMT in the coreboot build
Please reflow for 72 chars
Done
File src/soc/intel/xeon_sp/spr/Kconfig:
https://review.coreboot.org/c/coreboot/+/75416/comment/d6af8b5f_e4f18378 :
PS3, Line 185: EN_RMT
ENABLE_RMT
Done
File src/soc/intel/xeon_sp/spr/romstage.c:
https://review.coreboot.org/c/coreboot/+/75416/comment/2952e322_2ba3b87d :
PS3, Line 221: /* Enable RMT based on build config, default is disabled */
The comment seems superfluous. CONFIG() mostly refers to Kconfig variables. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75416?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b9276116c22cfbbec132d7a1b0026a52a51398a
Gerrit-Change-Number: 75416
Gerrit-PatchSet: 3
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 05 Jun 2023 08:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment