Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: fix LCMID to be 0x01 for Jacuzzi followers ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46442/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/46442/3/src/mainboard/google/kukui/... PS3, Line 196: uint32_t lcm_id = 1; give we're not reusing this later, move this to inside the config block, e.g.:
if (CONFIG...) { uint32_t lcm_id = 1; /* LCM is unused on Jacuzzi followers */ cached_sku_id = (lcm_id << 4 | get_adc_index(SKU_ID_CHANNEL)); ...