23 Mar
2019
23 Mar
'19
4:04 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22200 )
Change subject: nb/intel/sandybridge/raminit: Add extended memtest ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/22200/4/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/#/c/22200/4/src/northbridge/intel/sandybridge/ra... PS4, Line 461: ram_check(basek << 10, (basek + (1 << 10)) << 10);
That second argument has been ignored for ages now... […]
I agree. I'll have a look at the common API to get memory ranges next.
--
To view, visit https://review.coreboot.org/c/coreboot/+/22200
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31bcf8348c97b9461ee0aa792b3e53c0225d7d48
Gerrit-Change-Number: 22200
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 23 Mar 2019 07:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment