Attention is currently required from: Eric Lai, Felix Singer, Mario Scheithauer, Sean Rhodes, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75820?usp=email )
Change subject: soc/intel/apollolake: Fix FSP SATA speed limit configuraion
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/apollolake/ahci.c:
https://review.coreboot.org/c/coreboot/+/75820/comment/bd6ed9a9_2fc809c1 :
PS5, Line 12:
'is set, ' or 'is given, ', ...
...Or is this comment needed at all? It says exactly the same thing as the code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75820?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f55f40941fa618e7de13a5cefe9e17ae34c5c99
Gerrit-Change-Number: 75820
Gerrit-PatchSet: 5
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 10:21:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment