Attention is currently required from: Subrata Banik, Tim Wawrzynczak.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61217 )
Change subject: mb/google/brya/var/agah: Select PCIEXP_SUPPORT_RESIZABLE_BARS
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61217/comment/2f5bb33b_ab985007
PS1, Line 12: will may
NIT - pick one 😊
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/61217/comment/621cb6e1_a33e79ce
PS1, Line 10: PCIEXP_SUPPORT_RESIZABLE_BARS
NIT - might as well alphabetize this one like you did with DRIVERS_I2C_MAX98390.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61217
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cf86ba3160ae5018655b5d366e89f4273b30b94
Gerrit-Change-Number: 61217
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 04 Feb 2022 21:50:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment