Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56121 )
Change subject: arch/x86: smbios write 7 table using deterministic cache functions
......................................................................
Patch Set 4:
(1 comment)
File src/arch/x86/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123653):
https://review.coreboot.org/c/coreboot/+/56121/comment/f2f87400_4e034925
PS4, Line 811: struct cpu_cache_info info = fill_cpu_cahce_info(cnt++);
'cahce' may be misspelled - perhaps 'cache'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedbd3b745629dea57c3ad6b0d187eab2bcc3f7d3
Gerrit-Change-Number: 56121
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 08 Jul 2021 17:39:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment