11 Jan
2024
11 Jan
'24
10:08 p.m.
Attention is currently required from: Patrick Georgi.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email )
Change subject: libpayload: Remove shell for loops in install Makefile target ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Thank you for your answer. `{}` is not there: […]
Oh... I had to run it to actually understand what is happening. If my coreboot dir wouldn't be so cluttered, I would actually have noticed earlier that there is a spurious `src/commonlib/bsd/install` now oO
The current version only works if `$(DESTDIR)` is an absolute path, I'll push a patch...
--
To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210
Gerrit-Change-Number: 79523
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Patrick Georgi patrick@coreboot.org
Gerrit-Comment-Date: Thu, 11 Jan 2024 22:08:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment