Attention is currently required from: Cliff Huang, Hannah Williams, Jérémy Compostella, Subrata Banik, YH Lin.
Paul Menzel has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84408?usp=email )
Change subject: mb/google/fatcat: add GPIO pad configure based on fw_config
......................................................................
Patch Set 32:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84408/comment/a0a83ff0_6fc6c727?usp... :
PS32, Line 8:
Please elaborate. What sources did you use for the implementation?
https://review.coreboot.org/c/coreboot/+/84408/comment/1c1bdd91_f9ed3950?usp... :
PS32, Line 10: TEST=Boot on google fatcat board
What changed with this patch?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84408?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d54
Gerrit-Change-Number: 84408
Gerrit-PatchSet: 32
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: YH Lin
yueherngl@google.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 16 Oct 2024 05:52:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No