[coreboot-gerrit] Change in libgfxinit[master]: gma: Introduce `PCH_Type`

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/48762 )

Change subject: gma: Introduce `PCH_Type`
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/libgfxinit/+/48762/1/common/hw-gfx-gma-config.... 
File common/hw-gfx-gma-config.ads.template:

https://review.coreboot.org/c/libgfxinit/+/48762/1/common/hw-gfx-gma-config.... 
PS1, Line 21:    CPU_First : constant CPU_Type :=
            :      (case Gen is
            :          when G45       => G45,
            :          when Ironlake  => Ironlake,
            :          when Haswell   => Haswell,
            :          when Broxton   => Broxton,
            :          when Skylake   => Skylake);
            :    CPU_Last : constant CPU_Type :=
            :      (case Gen is
            :          when G45       => GM45,
            :          when Ironlake  => Ivybridge,
            :          when Haswell   => Broadwell,
            :          when Broxton   => Broxton,
            :          when Skylake   => Kabylake);
            :    CPU_Var_Last : constant CPU_Variant :=
            :      (case Gen is
            :          when Haswell | Skylake  => ULX,
            :          when others             => Normal);
            :    subtype Gen_CPU_Type is CPU_Type range CPU_First .. CPU_Last;
            :    subtype Gen_CPU_Variant is CPU_Variant range Normal .. CPU_Var_Last;
We can set something like this up for the PCH, too, to prevent misconfiguration.