Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42226 )
Change subject: mb/google/zork: Enable psp_verstage
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42226/10/src/mainboard/google/zork/...
File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42226/10/src/mainboard/google/zork/...
PS10, Line 171: help
Why is this a visible option? Does not build if selected and VBOOT=n.
https://review.coreboot.org/c/coreboot/+/42226/10/src/mainboard/google/zork/...
PS10, Line 178: select VBOOT_SEPARATE_VERSTAGE
This asymmetry is confusing to me, it's a VBOOT_SEPARATE_VERSTAGE=y in the VBOOT_STARTS_BEFORE_BOOTBLOCK case too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6a12c2074d7c84c0cb766393c66f5eff29a58d5
Gerrit-Change-Number: 42226
Gerrit-PatchSet: 10
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jul 2020 15:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment