Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros, Yu-Ping Wu.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59697 )
Change subject: libpayload: Add coreboot commonlib/bsd include path
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File payloads/libpayload/Makefile:
https://review.coreboot.org/c/coreboot/+/59697/comment/67bebc89_d5a06593
PS1, Line 37: :=
I'd propose "?=" here so it _can_ be overridden by people crazy enough for building libpayload without everything else around ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59697
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09f475d399ab785f3d3ffdb4b42950d2b397845e
Gerrit-Change-Number: 59697
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 30 Nov 2021 17:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment