Attention is currently required from: Tarun Tuli, Subrata Banik, Sridhar Siricilla.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: soc/intel/: Store CSE firmware version into cbmem table
......................................................................
Patch Set 11:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/d018ea4c_6968d601
PS10, Line 1093: version->cur_cse_fw_version.major = cse_bp->fw_ver.major;
: version->cur_cse_fw_version.minor = cse_bp->fw_ver.minor;
: version->cur_cse_fw_version.hotfix = cse_bp->fw_ver.hotfix;
: version->cur_cse_fw_version.build = cse_bp->fw_ver.build;
: }
You may use define and use generic function like cse_copy_fw_version() {https://review.coreboot. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8
Gerrit-Change-Number: 74256
Gerrit-PatchSet: 11
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 12:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment