Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 5: chip drivers/i2c/generic : register "hid" = ""10EC5682"" : register "name" = ""RT58"" : register "desc" = ""Headset Codec"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" : # Set the jd_src to RT5668_JD1 for jack detection : register "property_count" = "1" : register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" : register "property_list[0].name" = ""realtek,jd-src"" : register "property_list[0].integer" = "1" : device i2c 1a on : probe AUDIO MAX98357_ALC5682I_I2S : probe AUDIO MAX98373_ALC5682I_I2S : end : end
Dear Zhuohao, […]
My bad. sorry about that.
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... PS13, Line 55: device pci 15.2 on : end # I2C2 0xA0EA We can use the baseboard setting. Remove this?
https://review.coreboot.org/c/coreboot/+/42301/13/src/mainboard/google/volte... PS13, Line 67: device pci 1f.3 on : end We can use the baseboard setting. Remove this?