9 Jul
2019
9 Jul
'19
7:33 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34134 )
Change subject: cpu/x86: Declare SMM_ASEG ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34134/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801dx/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34134/2/src/southbridge/intel/i8280... PS2, Line 28: $(CONFIG_HAVE_SMI_HANDLER)
Can get rid of this?
Probably not, I think lapic_cpu_init.c would pull duplicate smm_init() definition.
I probably have this converted to TSEG soon anyway since this is broken, on paper at least. I have this legacy hardware to play around and for PCI-X slots.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34134
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b9007c55c75a59a9e6acc0a0e701300f7d21f87
Gerrit-Change-Number: 34134
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 09 Jul 2019 05:33:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment