Attention is currently required from: Martin Roth, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 )
Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This also breaks reproducibility guarantees because intermediate steps don't get an implicit order […]
no, macros and functions are evaluated in parse order. So when you add intermediates A, B, C, D, ... the current setup ensures that B depends on A, C on B and A, D on C, B, A, ... (which could be optimized by a small amount by removing the transitive dependencies), creating a stable execution order.
Without that order-only dependency, executing C, A, D, B would be a valid strategy (and depending on how many parallel make jobs you have and what happens in them, that might well happen).
I added that order-only target in https://review.coreboot.org/c/coreboot/+/49358 specifically to avoid race conditions that we were seeing...