Attention is currently required from: Shelley Chen, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
PS1: rk3399 also has lots of duplicate code. Would you like to remove it as well?
https://review.coreboot.org/c/coreboot/+/56965/comment/2a1a9b42_c012f04c PS1, Line 15: at a?
File src/device/mipi/Kconfig:
https://review.coreboot.org/c/coreboot/+/56965/comment/878d7842_24e35cdb PS1, Line 38: Extra blank line.
File src/include/device/mipi_panel.h:
https://review.coreboot.org/c/coreboot/+/56965/comment/d053b050_9541859b PS1, Line 11: PANEL_END_CMD I'd prefer consistent prefixes: PANEL_CMD_*.
https://review.coreboot.org/c/coreboot/+/56965/comment/ffd1abcf_81898b86 PS1, Line 24: that remove
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/56965/comment/7161cf1f_8bc1e1e8 PS1, Line 359: TODO It's considered an error according in rk_mipi_dsi_write().