Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56960 )
Change subject: soc/amd/common: Show current SPI speeds and modes ......................................................................
Patch Set 1:
(8 comments)
File src/soc/amd/common/block/include/amdblocks/spi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126164): https://review.coreboot.org/c/coreboot/+/56960/comment/da3548e1_8e873a3d PS1, Line 38: #define DECODE_SPI_READ_MODE(x) DECODE_SPI_MODE_UPPER_BITS(x) | \ Macros with complex values should be enclosed in parentheses
File src/soc/amd/common/block/spi/fch_spi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126164): https://review.coreboot.org/c/coreboot/+/56960/comment/4c8b9a81_bf7918ab PS1, Line 40: printk(BIOS_DEBUG,"SPI normal read speed: %s\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126164): https://review.coreboot.org/c/coreboot/+/56960/comment/88f5de34_2fae6e4f PS1, Line 42: printk(BIOS_DEBUG,"SPI fast read speed: %s\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126164): https://review.coreboot.org/c/coreboot/+/56960/comment/ea0f1b96_b98d5132 PS1, Line 44: printk(BIOS_DEBUG,"SPI alt read speed: %s\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126164): https://review.coreboot.org/c/coreboot/+/56960/comment/5bdecaee_aed3d875 PS1, Line 46: printk(BIOS_DEBUG,"SPI TPM read speed: %s\n", space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126164): https://review.coreboot.org/c/coreboot/+/56960/comment/9c23046e_604f9a9b PS1, Line 48: printk(BIOS_DEBUG,"SPI100: %s\n",spi_read16(SPI100_ENABLE) & SPI_USE_SPI100 ? space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126164): https://review.coreboot.org/c/coreboot/+/56960/comment/fb55a103_e346b904 PS1, Line 48: printk(BIOS_DEBUG,"SPI100: %s\n",spi_read16(SPI100_ENABLE) & SPI_USE_SPI100 ? space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126164): https://review.coreboot.org/c/coreboot/+/56960/comment/e9a681ef_0b458f32 PS1, Line 50: printk(BIOS_DEBUG,"SPI Read Mode: %s\n", space required after that ',' (ctx:VxV)