Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19657 )
Change subject: toolchain.inc: Use -Wstack-usage only on gcc
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/19657/1/toolchain.inc
File toolchain.inc:
PS1, Line 82: ifeq ($(CONFIG_COMPILER_GCC),y)
what about commenting here something like "restrict to GCC, not supported with Clang"? (improved)
--
To view, visit
https://review.coreboot.org/19657
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c22171dedc77df24e739ec26335010f0f443963
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philippe Mathieu-Daudé
philippe.mathieu.daude@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes