Ben Chuang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43751 )
Change subject: drivers/generic/genesyslogic: Add driver for Genesys Logic GL9763E
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43751/3/src/drivers/generic/genesys...
File src/drivers/generic/genesyslogic/gl9763e.c:
https://review.coreboot.org/c/coreboot/+/43751/3/src/drivers/generic/genesys...
PS3, Line 22: MAX_SSC_30000PPM);
nit: this fits on the previous line (coreboot's line length limit is 96 characters)
Oh. The length of Coreboot is longer than Linux. 😎
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I158c79f5ac6e559f335b6b50092469c7b1646c56
Gerrit-Change-Number: 43751
Gerrit-PatchSet: 4
Gerrit-Owner: Ben Chuang
benchuanggli@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Greg Tu
greg.tu@genesyslogic.com.tw
Gerrit-CC: HsuanYang Chen
ynop77@gmail.com
Gerrit-CC: Jerry Hu
jerry.huyc@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: 陳建宏
reniuschengl@gmail.com
Gerrit-Comment-Date: Fri, 24 Jul 2020 11:35:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment