Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42798 )
Change subject: drivers/mrc_cache: Avoid unused variable assignment
......................................................................
Patch Set 1:
Patch Set 1:
Strangely, for comparing with `BUILD_TIMELESS=1`, building the Lenovo ThinkPad X201 with `CONFIG_MRC_SETTINGS_PROTECT` selected, the object `mrc_cache.o` differs, but it’s stripped by the linker for `coreboot.rom`.
*snip*
Well, does moving the local variable declaration after the two conditional statements also change the binary?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c94b123f4994eed9d7568b63971fd5b1d94bc09
Gerrit-Change-Number: 42798
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 28 Jun 2020 10:37:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment