Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44476 )
Change subject: ec/kontron: add option to configure I2C frequency
......................................................................
Patch Set 9: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/44476/9/src/ec/kontron/kempld/kempl...
File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/44476/9/src/ec/kontron/kempld/kempl...
PS9, Line 53: mHz
MHz as 1000 kHz and not 0.001 Hz.
https://review.coreboot.org/c/coreboot/+/44476/9/src/ec/kontron/kempld/kempl...
PS9, Line 54: mHz
same here
https://review.coreboot.org/c/coreboot/+/44476/9/src/ec/kontron/kempld/kempl...
PS9, Line 239: unsigned short
Use u16 here to stay consistent with the rest of the code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0eb477af10d00eb4f17f9c01209f170b746ad3d
Gerrit-Change-Number: 44476
Gerrit-PatchSet: 9
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 31 Aug 2020 07:43:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
