Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43771 )
Change subject: mb/volteer: Disable TBT if platform is only USB3
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43771/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/43771/1/src/mainboard/google/voltee...
PS1, Line 39: }
I can add the DMA controllers to this... […]
while I do not believe it is necessary to turn off the DMAs in this case I have turned them both to off if the platform is USB3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43771
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I594f2e9483aaf896de2b6aea9a3460bd3826c58c
Gerrit-Change-Number: 43771
Gerrit-PatchSet: 2
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 28 Jul 2020 20:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment