Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44534 )
Change subject: soc/amd/common: add gpio subsystem event reporting ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44534/2/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/44534/2/src/soc/amd/common/block/gp... PS2, Line 310: begin i
https://review.coreboot.org/c/coreboot/+/44534/2/src/soc/amd/common/block/gp... PS2, Line 329: gpio_base = i * 4; This is overwriting the gpio_base value passed in by the caller.