Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46180 )
Change subject: mb/google/stout: Convert to ASL 2.0 syntax ......................................................................
mb/google/stout: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are identical.
Change-Id: I1ceb2abdd2562c145b01db7307d817c858d6b978 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46180 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/google/stout/acpi/mainboard.asl M src/mainboard/google/stout/acpi/platform.asl M src/mainboard/google/stout/acpi/thermal.asl 3 files changed, 16 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/google/stout/acpi/mainboard.asl b/src/mainboard/google/stout/acpi/mainboard.asl index 6cbe92e..f8cbe21 100644 --- a/src/mainboard/google/stout/acpi/mainboard.asl +++ b/src/mainboard/google/stout/acpi/mainboard.asl @@ -9,14 +9,14 @@
Method (_LID, 0) { - Store (_SB.PCI0.LPCB.EC0.HPLD, \LIDS) + \LIDS = _SB.PCI0.LPCB.EC0.HPLD Return (\LIDS) }
Method (_PSW, 1) { // Enable/Disable LID as a wake source - Store (Arg0, _SB.PCI0.LPCB.EC0.HWLO) + _SB.PCI0.LPCB.EC0.HWLO = Arg0 } } } diff --git a/src/mainboard/google/stout/acpi/platform.asl b/src/mainboard/google/stout/acpi/platform.asl index 8220599..b3421d5 100644 --- a/src/mainboard/google/stout/acpi/platform.asl +++ b/src/mainboard/google/stout/acpi/platform.asl @@ -7,7 +7,7 @@ Method(_PTS,1) { // Notify EC to enter S3 - Store(0x01, _SB.PCI0.LPCB.EC0.S3FG) + _SB.PCI0.LPCB.EC0.S3FG = 0x01 }
/* The _WAK method is called on system wakeup */ @@ -15,16 +15,16 @@ Method(_WAK,1) { /* Update AC status */ - Store (_SB.PCI0.LPCB.EC0.ACPW, Local0) - if (LNotEqual (Local0, \PWRS)) { - Store (Local0, \PWRS) + Local0 = _SB.PCI0.LPCB.EC0.ACPW + if (Local0 != \PWRS) { + \PWRS = Local0 Notify (_SB.PCI0.LPCB.EC0.AC, 0x80) }
/* Update LID status */ - Store (NOT(_SB.PCI0.LPCB.EC0.HPLD), Local0) - if (LNotEqual (Local0, \LIDS)) { - Store (Local0, \LIDS) + Local0 = ~_SB.PCI0.LPCB.EC0.HPLD + if (Local0 != \LIDS) { + \LIDS = Local0 Notify (_SB.LID0, 0x80) }
diff --git a/src/mainboard/google/stout/acpi/thermal.asl b/src/mainboard/google/stout/acpi/thermal.asl index 2484332..de5a7ef 100644 --- a/src/mainboard/google/stout/acpi/thermal.asl +++ b/src/mainboard/google/stout/acpi/thermal.asl @@ -22,10 +22,10 @@ Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
// Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) } @@ -51,21 +51,21 @@ Method (_TMP, 0, Serialized) { // Returns Higher of the two readings for CPU & VGA Temperature - If (LGreater (_SB.PCI0.LPCB.EC0.TMP2, _SB.PCI0.LPCB.EC0.TMP1)) + If (_SB.PCI0.LPCB.EC0.TMP2 > _SB.PCI0.LPCB.EC0.TMP1) { // CPU high temperature - Store (_SB.PCI0.LPCB.EC0.TMP2, Local0) + Local0 = _SB.PCI0.LPCB.EC0.TMP2 } Else { // VGA high temperature - Store (_SB.PCI0.LPCB.EC0.TMP1, Local0) + Local0 = _SB.PCI0.LPCB.EC0.TMP1 }
// If temp less 35 or great then 115, set default 35 - If (Or (LLess (Local0, 35), LGreater (Local0, 115))) + If ((Local0 < 35) | (Local0 > 115)) { - Store (35, Local0) + Local0 = 35 }
Return (CTOK (Local0))