Attention is currently required from: Joel Kitching, Roger Lu, Yidi Lin, Yuchen Huang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )
Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................
Patch Set 64:
(5 comments)
File src/soc/mediatek/mt8192/srclken_rc.c:
https://review.coreboot.org/c/coreboot/+/46878/comment/38269ca5_24119184
PS64, Line 13: (
No need for parentheses.
https://review.coreboot.org/c/coreboot/+/46878/comment/da89d3be_88442eef
PS64, Line 104: 0x0
Align with DCXO_STABLE_TIME
https://review.coreboot.org/c/coreboot/+/46878/comment/0c22dd1a_9242afd0
PS64, Line 278: )
Move ")" right after 16.
https://review.coreboot.org/c/coreboot/+/46878/comment/4a2ebb67_88dac447
PS64, Line 354: 0
No initialization.
https://review.coreboot.org/c/coreboot/+/46878/comment/d8f5e866_f6d10e78
PS64, Line 365: retry--
Sorry I was wrong. This should be "--retry", so that after the last failure, 'retry' will be 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I947bf14df7a307bf359c590c2a20265882b3f1be
Gerrit-Change-Number: 46878
Gerrit-PatchSet: 64
Gerrit-Owner: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ran Bi
ran.bi@mediatek.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yuchen Huang
yuchen.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Joel Kitching
kitching@google.com
Gerrit-Attention: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Attention: Yuchen Huang
yuchen.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 15 Jan 2021 08:15:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment