Ivan Vatlin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38143 )
Change subject: mb/asus/p5qc: Add ASUS P5Q as a variant (with documentation) ......................................................................
Patch Set 13:
(9 comments)
I'll post `lspci -nntv` log later
https://review.coreboot.org/c/coreboot/+/38143/1//COMMIT_MSG Commit Message:
PS1:
Right, so the tested and working things can go into the documentation. […]
With so much items in list I should use a three column table (IMHO)
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... File Documentation/mainboard/asus/p5q.md:
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... PS12, Line 3: desktop
desktop *board*
Fixed
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... PS12, Line 9: The following things are untested on this coreboot port:
Add an extra blank line before untested things
Still mastering my markdown, fixed
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... PS12, Line 27: No?
Untested, likely does not work.
Deleted since chip is socketed
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... PS12, Line 29: SOIC-8
Socketed DIP-8
Changed
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... PS12, Line 53: Intel ME?
It is disabled (does not have any firmware) on your board
Changed
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... PS12, Line 55: ???
See mainboard: http://diy.yesky.com/imagelist/2008/167/1b529813etl1.jpg […]
Thanks for your sharp eyes :D
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/var... File src/mainboard/asus/p5qc/variants/p5q/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/var... PS1, Line 71: device pnp 2e.0 off end # FDC : device pnp 2e.1 off end # LPT1 : device pnp 2e.2 on # COM1 : # Global registers : irq 0x2a = 0x00 : irq 0x2c = 0x22 : irq 0x2d = 0x00 : io 0x60 = 0x3f8 : irq 0x70 = 4 : end
Floppy is enabled on your board: […]
I connected my old FDD to test it but OS didn't detect floppy disk Need some workaround
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/var... PS1, Line 124: IDE
If you want, you can update the comment. […]
Changed