Attention is currently required from: Nico Huber, Michael Niewöhner, HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )
Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45273/comment/cb32e9b6_b27e4e84
PS11, Line 12: instructions, but the ASL v2 compiler does have.
Please wrap lines at 72 characters:
Generated 'build/dsdt.dsl' files for ibase/mb899 are identical.
Since the "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and
"^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)" statements get optimized
differently by the ASL v2 compiler, the resulting binary changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c
Gerrit-Change-Number: 45273
Gerrit-PatchSet: 11
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 17 Feb 2021 09:53:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
