Attention is currently required from: Tim Wawrzynczak, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62914 )
Change subject: soc/intel/alderlake: Add UfsEnable parameter ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62914/comment/223ffe65_1127f5f8 PS1, Line 620: s_cfg->UfsEnable[0] = is_devfn_enabled(PCH_DEVFN_UFS); This is very weird, as per EDS, ADL-N supports only 1 UFS controller but FSP code assumes/kept placeholder for 2 UFS controller and later relying on PMC register 0x1E44 to know if 2nd UFS controller is enable or not.
So, unfortunately we need to keep a comment somewhere saying UfsEnable[1] is false to avoid confusion in future.