HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41255 )
Change subject: src/include/gpio.h: Drop 'include <soc/gpio.h>'
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41255/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41255/1//COMMIT_MSG@9
PS1, Line 9: include <soc/gpio.h> in 'src/include/gpio.h' does not make sense.
Uhh... yeah it does, this is intentional. […]
looks like this file is only used by soc.
what I don't understand is why should we include 'soc' in common part of coreboot tree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38deed0981032ff3aacc71e2b1afb8fac7dbf62a
Gerrit-Change-Number: 41255
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 May 2020 20:09:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment