[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Add weak function definitions to get ioapic IDs

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46326 )

Change subject: soc/amd/common: Add weak function definitions to get ioapic IDs
......................................................................

Patch Set 3:

wouldn't a #define AMD_SOC_FCH_IOAPIC_ID CONFIG_MAX_CPUS and #define AMD_SOC_GNB_IOAPIC_ID (CONFIG_MAX_CPUS + 1) somewhere in a soc-specific header file also do the trick? If there's a reasonably easy way to avoid weak functions, I'd use that instead. just tried that assigning MAX_CPUS + 1 to PICASSO_GNB_IOAPIC_ID won't work due to kconfig not supporting arithmetic for the default values, so that wouldn't be an option here