Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33760 )
Change subject: soc/amd/picasso: Make romstage a hybrid
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33760/1/src/soc/amd/picasso/include/soc/roms...
File src/soc/amd/picasso/include/soc/romstage.h:
https://review.coreboot.org/#/c/33760/1/src/soc/amd/picasso/include/soc/roms...
PS1, Line 26: truct early_saved_info {
: uint32_t unused;
: uint32_t bist;
: uint64_t early_tsc;
: } __packed;
:
Nice trick pushing it into stack and landing in the structure. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c3dc68463d2027d2b1e68e15708cfb6a84f1b39
Gerrit-Change-Number: 33760
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jul 2019 23:40:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment