Attention is currently required from: Eric Lai, Kapil Porwal, Subrata Banik, Tarun Tuli.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75827?usp=email )
Change subject: mb/google/rex: Set AUX orientation at SoC to follow cable for anx7452
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rex/variants/rex0/variant.c:
https://review.coreboot.org/c/coreboot/+/75827/comment/2b998314_338097dd :
PS1, Line 12: TCP_AUX_FOLLOW_CC2
nit: if you don't use this, you don't define it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75827?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb9f442d2afd81fb5dde4bca97c15457837f9f4a
Gerrit-Change-Number: 75827
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 03:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment