Attention is currently required from: Kapil Porwal, Paul Menzel, Ronak Kanabar.
Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83404?usp=email )
Change subject: vc/intel/fsp/twinlake: Update FSP headers to v5222.01
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83404/comment/c1a82555_bd7e0824?usp... :
PS4, Line 7: vc/intel/fsp/twinlake: Update FSP headers from v5142.00 to v5222.01
:
: Update generated FSP headers for Twin Lake from v5222.01
:
: Changes include:
: - Add Usb4CmMode & CnviWifiCore Upd in FspsUpd.h
: - Update UPD Offset in FspsUpd.h
:
vc/intel/fsp/twinlake: Update FSP headers to v5222.01 […]
Done
https://review.coreboot.org/c/coreboot/+/83404/comment/cc416816_1d52631b?usp... :
PS4, Line 16: nivviks
this is TWL FSP hence, should be either Tivviks or trulo
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83404?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia68b6aa90c782a359b594f381e223772a897c6e6
Gerrit-Change-Number: 83404
Gerrit-PatchSet: 5
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Fri, 26 Jul 2024 18:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com