Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45590 )
Change subject: soc/intel/common/block/lpc: add acpi name ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/... File src/soc/intel/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/... PS1, Line 101: LPCB
Thanks. […]
Actually CONFIG_SOC_INTEL_COMMON_BLOCK_LPC is selected for all the above SoCs:
# git grep "select SOC_INTEL_COMMON_BLOCK_LPC" src/soc/intel/apollolake/Kconfig: select SOC_INTEL_COMMON_BLOCK_LPC src/soc/intel/common/pch/Kconfig: select SOC_INTEL_COMMON_BLOCK_LPC src/soc/intel/xeon_sp/Kconfig: select SOC_INTEL_COMMON_BLOCK_LPC
In common/pch/Kconfig, SOC_INTEL_COMMON_BLOCK_LPC is auto-selected if SOC_INTEL_COMMON_PCH_BASE is selected.
# git grep "select SOC_INTEL_COMMON_PCH_BASE" src/soc/intel/alderlake/Kconfig: select SOC_INTEL_COMMON_PCH_BASE src/soc/intel/cannonlake/Kconfig: select SOC_INTEL_COMMON_PCH_BASE src/soc/intel/elkhartlake/Kconfig: select SOC_INTEL_COMMON_PCH_BASE src/soc/intel/icelake/Kconfig: select SOC_INTEL_COMMON_PCH_BASE src/soc/intel/jasperlake/Kconfig: select SOC_INTEL_COMMON_PCH_BASE src/soc/intel/skylake/Kconfig: select SOC_INTEL_COMMON_PCH_BASE src/soc/intel/tigerlake/Kconfig: select SOC_INTEL_COMMON_PCH_BASE