Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42692 )
Change subject: soc/amd/common: Avoid aliasing on ACPIMMIO writes ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42692/5/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio.h:
https://review.coreboot.org/c/coreboot/+/42692/5/src/soc/amd/common/block/in... PS5, Line 35: union std_bank { : uint8_t reg8[0x100]; : uint16_t reg16[0x100 / sizeof(uint16_t)]; : uint32_t reg32[0x100 / sizeof(uint32_t)]; : }; Is the code density really worth using this pattern? I'm not a fan.