Attention is currently required from: Martin L Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67319 )
Change subject: util/release/build-release: Fix style issues ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
File util/release/build-release:
https://review.coreboot.org/c/coreboot/+/67319/comment/c2387570_f6b75a69 PS1, Line 12: set -e If you wanted to make it even more robust:
``` set -eu -o pipefail ```
https://review.coreboot.org/c/coreboot/+/67319/comment/403b8333_4a642bc4 PS1, Line 65: -- Why the `--`?
https://review.coreboot.org/c/coreboot/+/67319/comment/e9f1172d_81f37caf PS1, Line 80: cat "coreboot-${VERSION_NAME}/.coreboot-version" | tr "-" " " nit: `tr "-" " " < "coreboot-${VERSION_NAME}/.coreboot-version"`