23 Aug
2024
23 Aug
'24
12:09 p.m.
Attention is currently required from: Angel Pons, Jérémy Compostella.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84052?usp=email )
Change subject: car.ld: Fix bug with LLD ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84052/comment/01d15908_8979980e?usp... : PS5, Line 10: not used
How exactly is it not used? I thought it was used by MRC
This section contains no symbols and there are no symbols related to it's size so that's why it is unused. It was wrong to remove the computation from the linker script so I added it in a different way.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84052?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9cdd1b509bb9ff449e692109a4b674f8bfd732a4
Gerrit-Change-Number: 84052
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 23 Aug 2024 10:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com