Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33823 )
Change subject: include, lib: Add <inttypes.h> printf macros
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33823/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33823/14//COMMIT_MSG@11
PS14, Line 11: useful for portably printing them. Of these definitions, coreboot so far has
: only used PRIu64 (in one place), which isn't needed anymore since we know
overlong lines btw.
https://review.coreboot.org/c/coreboot/+/33823/14/src/lib/timestamp.c
File src/lib/timestamp.c:
https://review.coreboot.org/c/coreboot/+/33823/14/src/lib/timestamp.c@184
PS14, Line 184: timestamp_name(id), ts_time);
Mostly to be consistent with the rest of the code base, which doesn't use PRIu64 anywhere else (or a […]
Well, I would see PRIu64 as a courtesy to the reviewer, so they don't
have to know our uint64_t implementation details. Consistency is a good
argument, too. Feel free to remove the line break, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e3a300f9b1c38e4831b030ff8af3fed2fa60f14
Gerrit-Change-Number: 33823
Gerrit-PatchSet: 14
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Aug 2019 07:25:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment