Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Jérémy Compostella, Krystian Hebel, Matt DeVillier, Michał Żygowski, Raul Rangel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162?usp=email )
Change subject: security/tpm: support compiling in multiple TPM drivers
......................................................................
Patch Set 32:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69162/comment/b04a35b0_2c3bce3c :
PS31, Line 14: Makefile.inc files were updated to replace `all-*` with romstage,
CONFIG_TPM_MEASURED_BOOT_INIT_BOOTBLOCK uses TPM in bootblock. […]
It was "uncovered" by way of failing the build due to unresolved references to TSS implementation as far as I remember. But it was in 2022, will see what CI will say today with `all-y`.
File src/security/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/69162/comment/d4365028_d16b10f9 :
PS31, Line 100: config TPM_LOG_TPM1
: bool "TPM 1.2 format"
: depends on TPM1
: help
: Log per TPM 1.2 specification.
: See "TCG PC Client Specific Implementation Specification for Conventional BIOS".
: config TPM_LOG_TPM2
: bool "TPM 2.0 format"
: depends on TPM2
: help
: Log per TPM 2.0 specification.
: See "TCG PC Client Platform Firmware Profile Specification".
Now that we can have either a TPM1.2 or TPM2. […]
TPM_LOG_TPM1 implements the first spec as its help text specifies:
https://trustedcomputinggroup.org/wp-content/uploads/TCG_PCClientImplementat...
The other one isn't implemented.
Different log formats are mutually exclusive, so I only updated this `Kconfig`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69162?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44c5a1d825afe414c2f5c2c90f4cfe41ba9bef5f
Gerrit-Change-Number: 69162
Gerrit-PatchSet: 32
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 14 Feb 2024 18:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment