Attention is currently required from: Kacper Stojek, Paul Menzel.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68474 )
Change subject: util/inteltool: Add support for Elkhart lake ......................................................................
Patch Set 6:
(8 comments)
File util/inteltool/gpio_names/elkhartlake.h:
https://review.coreboot.org/c/coreboot/+/68474/comment/e064c681_8a4a74de PS6, Line 447: "VGPIO_0", "n/a", : "VGPIO_4", "n/a", : "VGPIO_5", "n/a", : "VGPIO_6", "n/a", : "VGPIO_7", "n/a", : "VGPIO_8", "n/a", : "VGPIO_9", "n/a", : "VGPIO_10", "n/a", : "VGPIO_11", "n/a", : "VGPIO_12", "n/a", : "VGPIO_13", "n/a", : "VGPIO_18", "n/a", : "VGPIO_19", "n/a", : "VGPIO_20", "n/a", : "VGPIO_21", "n/a", : "VGPIO_22", "n/a", : "VGPIO_23", "n/a", : "VGPIO_24", "n/a", : "VGPIO_25", "n/a", : "VGPIO_30", "n/a", : "VGPIO_31", "n/a", : "VGPIO_32", "n/a", : "VGPIO_33", "n/a", : "VGPIO_34", "n/a", : "VGPIO_35", "n/a", : "VGPIO_36", "n/a", : "VGPIO_37", "n/a", : "VGPIO_39", "n/a", I guess VGPIOs have only 1 native function which is VGPIOx, so I would suggest to change it to: "VGPIO_0", "VGPIO_0", "VGPIO_4", "VGPIO_4",
etc.
https://review.coreboot.org/c/coreboot/+/68474/comment/60432986_757b6597 PS6, Line 486: "VGPIO_USB_0", "n/a", : "VGPIO_USB_1", "n/a", : "VGPIO_USB_2", "n/a", : "VGPIO_USB_3", "n/a", "VGPIO_USB_0", "VGPIO_USB_0", "VGPIO_USB_1", "VGPIO_USB_1", "VGPIO_USB_2", "VGPIO_USB_2", "VGPIO_USB_3", "VGPIO_USB_3",
https://review.coreboot.org/c/coreboot/+/68474/comment/bff29a6b_8fb67263 PS6, Line 501: &elkhartlake_pch_group_t, : &elkhartlake_pch_group_g, Bad indent
https://review.coreboot.org/c/coreboot/+/68474/comment/ac9c2b99_fd5d65c3 PS6, Line 528: &elkhartlake_pch_group_gpd, Bad indent
https://review.coreboot.org/c/coreboot/+/68474/comment/b4d10288_29818f5e PS6, Line 539: &elkhartlake_pch_group_s, : &elkhartlake_pch_group_a, : &elkhartlake_pch_group_vgpio_usb, Bad indent
https://review.coreboot.org/c/coreboot/+/68474/comment/62b3badd_3dd1b3c0 PS6, Line 552: &elkhartlake_pch_group_c, : &elkhartlake_pch_group_f, : &elkhartlake_pch_group_e, Bad indent
https://review.coreboot.org/c/coreboot/+/68474/comment/247563a6_2e3014a5 PS6, Line 565: &elkhartlake_pch_group_r, Bad indent
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/68474/comment/579b7481_93c883c7 PS6, Line 300: #define PCI_DEVICE_ID_INTEL_EHL 0x4b00 One TAB more? It seems not to be aligned properly with above defines
BTW coreboot defines more ESPI IDs:
#define PCI_DID_INTEL_MCC_ESPI_0 0x4b00 #define PCI_DID_INTEL_MCC_ESPI_1 0x4b04 #define PCI_DID_INTEL_MCC_BASE_ESPI 0x4b03 #define PCI_DID_INTEL_MCC_PREMIUM_ESPI 0x4b02 #define PCI_DID_INTEL_MCC_SUPER_ESPI 0x4b01 #define PCI_DID_INTEL_MCC_ESPI_2 0x4b05 #define PCI_DID_INTEL_MCC_ESPI_3 0x4b06 #define PCI_DID_INTEL_MCC_ESPI_4 0x4b07
I don't know how many of these one may encounter on production devices though