Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Ravishankar Sarawadi, Saurabh Mishra, Wonkyu Kim.
Subrata Banik has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/83772?usp=email )
Change subject: soc/intel/ptl: Add SoC ACPI directory for Panther Lake ......................................................................
Patch Set 125:
(15 comments)
Patchset:
PS125: s
File src/soc/intel/pantherlake/acpi/camera_clock_ctl.asl:
https://review.coreboot.org/c/coreboot/+/83772/comment/272cead1_af86efcd?usp... : PS125, Line 4: #define B_ICLK_PCR_FREQUENCY 0x1 Please add a TODO for pending ICLK register details in EDS and/or equivalent
File src/soc/intel/pantherlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/83772/comment/8597c88b_56bc4ad3?usp... : PS123, Line 216: Sleep (100)
why we need static delay, this will impact the sleep_resume time KPI which is 500ms. […]
Acknowledged
File src/soc/intel/pantherlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/83772/comment/8cdb99bb_1632843e?usp... : PS125, Line 405: , 2, why we need this ?
https://review.coreboot.org/c/coreboot/+/83772/comment/fddde4c2_17120838?usp... : PS125, Line 608: /* : * FIXME: Remove this workaround after resolving b/244082753 : * : * Document #742990: TCCold exit flow may not complete when processor at package : * C0. The implication is that the system may hang. : */ remove stale comments
File src/soc/intel/pantherlake/acpi/tcss_pcierp.asl:
https://review.coreboot.org/c/coreboot/+/83772/comment/d8bc0a3f_a6fb462d?usp... : PS125, Line 39: LNRE, 1, please add a description for this bit-field
https://review.coreboot.org/c/coreboot/+/83772/comment/c0b494d7_00d4b23c?usp... : PS125, Line 43: LSOE, 1, : LNSE, 1, same
https://review.coreboot.org/c/coreboot/+/83772/comment/d58bc509_b2dbc0e3?usp... : PS125, Line 49: 0x5BC 0x5bc
https://review.coreboot.org/c/coreboot/+/83772/comment/0cfa4a7a_c1280b3c?usp... : PS125, Line 53: 0xBA8 in smaller case
https://review.coreboot.org/c/coreboot/+/83772/comment/070cd415_9603e6d8?usp... : PS125, Line 57: 0xBB2 same
https://review.coreboot.org/c/coreboot/+/83772/comment/a15fcd82_1fbfb852?usp... : PS125, Line 65: 0xDC same
https://review.coreboot.org/c/coreboot/+/83772/comment/eb22ff23_46bc8e68?usp... : PS125, Line 212: } please allow one empty line between 212 and 213
File src/soc/intel/pantherlake/acpi/tcss_xhci.asl:
https://review.coreboot.org/c/coreboot/+/83772/comment/3760066d_727092eb?usp... : PS125, Line 37: /* D3COLD_SUPPORT */ nit: can you please drop tthis comment
https://review.coreboot.org/c/coreboot/+/83772/comment/3453a24d_f11f0ade?usp... : PS125, Line 56: // D3COLD_SUPPORT same
File src/soc/intel/pantherlake/acpi/xhci.asl:
https://review.coreboot.org/c/coreboot/+/83772/comment/9647640d_f1da6b93?usp... : PS125, Line 29: Pantherlake please remove this entire line, we are inside PTL soc