Attention is currently required from: Angel Pons, Kyösti Mälkki, Elyes Haouas, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69339 )
Change subject: Revert "mb/aopen/dxplplusu: Remove board" ......................................................................
Patch Set 2:
(1 comment)
File src/cpu/intel/model_f2x/model_f2x_init.c:
https://review.coreboot.org/c/coreboot/+/69339/comment/f7bad1ad_628f9cff PS2, Line 17: if (!intel_ht_sibling()) { : /* MTRRs are shared between threads */ : x86_setup_mtrrs(); : x86_mtrr_check(); : : /* Update the microcode */ : intel_update_microcode_from_cbfs(); : } : : /* Start up my CPU siblings */ : intel_sibling_init(cpu); This can be dropped if mp_ops has .pre_mp_ops: static void pre_mp_init(void) { const void *patch = intel_microcode_find(); intel_microcode_load_unlocked(patch);
/* Setup MTRRs based on physical address size. */ x86_setup_mtrrs_with_detect(); x86_mtrr_check(); } .get_microcode_info: static void get_microcode_info(const void **microcode, int *parallel) { *microcode = intel_microcode_find(); *parallel = !intel_ht_supported(); }