Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45458 )
Change subject: mb/google/dedede: Enable I2C5 pads ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45458/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45458/1//COMMIT_MSG@9 PS1, Line 9: Waddledee
Wait did Doo change too? The sentence was trying to convey that one specific variant needs it (even […]
Yes, since you changed in baseboard it applies to all the variants.
https://review.coreboot.org/c/coreboot/+/45458/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/45458/1/src/mainboard/google/dedede... PS1, Line 187: AP_I2C_SUB_SDA
In the event we are not sure about the plan for other variants, please move this configuration to va […]
Boten wants to use I2C5 for Proximity Sensor - https://review.coreboot.org/c/coreboot/+/43478.
Given that we are using I2C5 in select variants, we can move it to override GPIO config in variants. Also we can add a comment stating the purpose of this GPIO.