SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35532 )
Change subject: mb/google/kohaku: Update DPTF parameters and TCC offset setting ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35532/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/35532/1/src/mainboard/google/hatch/... PS1, Line 21: EC_ENABLE_MULTIPLE_DPTF_PROFILES
This is not mentioned in commit message.
Done
https://review.coreboot.org/c/coreboot/+/35532/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35532/1/src/mainboard/google/hatch/... PS1, Line 2: 8
Shouldn't this be updated to match what is in asl file?
We would use 8W for this. (Thermal guy's feedback)