25 Feb
2019
25 Feb
'19
3:33 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31552 )
Change subject: soc/intel/cannonlake: Update GPIO definitions for Virtual GPIO ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31552/3/src/soc/intel/cannonlake/acpi/gpio.a... File src/soc/intel/cannonlake/acpi/gpio.asl:
https://review.coreboot.org/#/c/31552/3/src/soc/intel/cannonlake/acpi/gpio.a... PS3, Line 83: GPIO_RSVD_12 Shouldn't this be vSD3_CD_B?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31552
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4da161b91f83749b0ae29b387b5c99c1c3f706d8
Gerrit-Change-Number: 31552
Gerrit-PatchSet: 3
Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 25 Feb 2019 03:33:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment