Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59511 )
Change subject: Makefiles: Hide skipping submodule info unless V=1 ......................................................................
Makefiles: Hide skipping submodule info unless V=1
Currently, git prints out the submodules that are being skipped twice on many builds. This patch hides that output unless the build is set to show it with `make V=1`. This is the normal way of showing the extra information during the build.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: I7b5c7f1f79dcc88793a9a21f2e92e7accc5de1e0 --- M Makefile M Makefile.inc 2 files changed, 9 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/59511/1
diff --git a/Makefile b/Makefile index 97ed805..c148c11 100644 --- a/Makefile +++ b/Makefile @@ -63,6 +63,7 @@ ifneq ($(Q),) .SILENT: MAKEFLAGS += -s +quiet_errors := 2>/dev/null endif endif
diff --git a/Makefile.inc b/Makefile.inc index f14bc1e..1b1e973 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -189,29 +189,29 @@ ifeq ($(CONFIG_COVERAGE),y) ramstage-c-ccopts += -fprofile-arcs -ftest-coverage endif - ifneq ($(UPDATED_SUBMODULES),1) # try to fetch non-optional submodules if the source is under git -forgetthis:=$(if $(GIT),$(shell git submodule update --init)) +forgetthis:=$(if $(GIT),$(shell git submodule update --init $(quiet_errors))) # Checkout Cmocka repository -forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/cmocka)) +forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/cmocka $(quiet_errors))) ifeq ($(CONFIG_USE_BLOBS),y) # These items are necessary because each has update=none in .gitmodules. They are ignored # until expressly requested and enabled with --checkout -forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) -forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) +forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs $(quiet_errors))) +forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode $(quiet_errors))) ifeq ($(CONFIG_FSP_USE_REPO),y) -forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp)) +forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp $(quiet_errors))) endif ifeq ($(CONFIG_USE_AMD_BLOBS),y) -forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/amd_blobs)) +forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/amd_blobs $(quiet_errors))) endif ifeq ($(CONFIG_USE_QC_BLOBS),y) -forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/qc_blobs)) +forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/qc_blobs $(quiet_errors))) endif endif UPDATED_SUBMODULES:=1 COREBOOT_EXPORTS += UPDATED_SUBMODULES + endif
postcar-c-deps:=$$(OPTION_TABLE_H)