9 Jul
2024
9 Jul
'24
8:14 p.m.
Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/83390?usp=email )
Change subject: nb/via/cx700: Implement PCI function disablement ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/northbridge/via/cx700/chip.c:
https://review.coreboot.org/c/coreboot/+/83390/comment/83bae741_a5cb5451?usp... : PS1, Line 36: dev->enabled || _dev_uhci1_ptr->enabled || nit: why is this a tab?
```suggestion dev->enabled || _dev_uhci1_ptr->enabled || ```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83390?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97ac61bca336465ce64e1c2b57d40e7ddd7f2643
Gerrit-Change-Number: 83390
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 09 Jul 2024 18:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes