Attention is currently required from: Tim Wawrzynczak, Julius Werner, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56726 )
Change subject: soc/intel: Add new Kconfig INTEL_ALLOW_SOC_DEBUG_HOOKS ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56726/comment/49798b78_b46c15ee PS4, Line 9: The intent of this Kconfig is, when selected, to compile in any : Intel-specific hooks that may be available. If the intent of the Kconfig is to compile in any Intel-specific hooks, then shouldn't the SoCs add something like:
``` config INTEL_ALLOW_SOC_DEBUG_HOOKS select X select Y ```
rather than
``` config X depends on INTEL_ALLOW_SOC_DEBUG_HOOKS ```
In the follow up CLs, it looks like the config is used to establish a dependency of SoC-specific configs on INTEL_ALLOW_SOC_DEBUG_HOOKS so that the SoC-specific hooks are available to be selected only when INTEL_ALLOW_SOC_DEBUG_HOOKS is selected.
Also, do we want this to be Intel-specific config or should this be a common config in src/Kconfig that can be used as required by each SoC?